Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type
joe.darcy at oracle.com
Fri Apr 5 18:39:36 UTC 2013
On 04/05/2013 05:46 AM, Alan Bateman wrote:
> On 03/04/2013 17:38, Joe Darcy wrote:
>> Hi Peter,
>> On 04/03/2013 01:26 AM, Peter Levart wrote:
>>> Hi Joe,
>>> Why not using StringBuilder instead of StringBuffer in
>>> Class.toGenericString ?
>> No reason. Thanks for catching this; I'll use StringBuilder in the
>> final push.
> Modifier.toString can probably be updated too.
> I looked through the changes and they look okay to me. For the
> toGenericString javadoc then "formatted as a list" might be better
> than "formatted as list".
I'll correct that as well.
More information about the core-libs-dev