Review Request: JDK-8011602 - jobjc build failure on Mac
dan.xu at oracle.com
Fri Apr 5 22:35:03 UTC 2013
Please review the change to fix the build issue on mac platformat
http://cr.openjdk.java.net/~dxu/8011602/webrev/.It removes the
un-necessary @Native annotation from
Therefore, the objc compilation will not dependon the new
java.lang.annotation.Native interfacethat is only introduced in jdk8.
For the normalbuild process, even though @Native annotationis added to
many other java classes to replace @GenerateNativeHeader, the langtool
has the capability to handle that when building with jdk7. But on Mac
platform, objc compilation is a special process, where the magic of
langtool to handle new jdk8 interface in old jdk7 cannot be applied.
Since Coder.java already has a native method,
getNativeFFITypePtrForCode(), declared, @Native is notnecessary to be
present, and it is safe to remove them. The other change in file,
src/share/classes/sun/java2d/opengl/OGLContext.java, is only a format
correction. I have tested this fix in jprt with boot jdk as jdk7 across
all platforms. Thanks!
More information about the core-libs-dev