Christos Zoulas christos at zoulas.com
Wed Apr 10 18:24:46 UTC 2013

On Apr 10,  1:54pm, john.zavgren at oracle.com (John Zavgren) wrote:
-- Subject: Re: RFR-8008118

| Your comments are welcome.

1. We did we switch from NEW() to xmalloc()? Why is the xmalloc cast needed?
2. I would not declare pathv "const char **", but "char **", and then
   cast the return if needed. This will make life easier in the future
   if we decide to turn on warnings about const-castaways.

Otherwise LGTM.


More information about the core-libs-dev mailing list