[PATCH] Review Request for 8009258: TEST_BUG: java/io/pathNames/GeneralWin32.java fails intermittently
dan.xu at oracle.com
Wed Apr 17 18:12:34 UTC 2013
On 04/17/2013 02:15 AM, Alan Bateman wrote:
> On 17/04/2013 07:36, Dan Xu wrote:
>> In the changes, the usages of NIO classes are not necessary. The test
>> is against java.io packages, and it is better to keep it clean in
>> case it might be used to test old jdk version which does not have NIO.
> I briefly looked at it and I think the usage okay is because it just
> makes it easier to check the results and also to keep the directory
> walk from wandering into other parts of the file system. If it changed
> what was being tested then I would agree that it shouldn't be used.
I see. My thought is that the relative path between baseDir and userDir
can be calculated inside initTestData() when it constructs the baseDir.
But I agree it is not an issue here. Thanks!
More information about the core-libs-dev