Add getChars to CharSequence
Alan.Bateman at oracle.com
Tue Apr 23 11:17:46 UTC 2013
On 22/04/2013 20:45, Martin Buchholz wrote:
> Another preliminary webrev is out at
> Alan et al: Before continuing, can we:
> Have thumbs up on the changes to out of bounds exceptions?
I looked over the bound checking. The only one that isn't clear is
AbstractStringBuilder.insert where dstOffset is specified to be greater
than this.length rather than count.
> The handling of the rw conditional in the preprocessed sources is very
> confusing and error-prone. I cleaned up some of that code and added
> tests to catch the most obvious mistakes. We can do this all in a
> single changeset, but if you like, we can separate the general nio
> buffer improvements into a separate changeset; if so, file a bug.
The templates are complicated to work with. Can you provide more details
on the issues that you found? I grabbed the changes to the buffer tests
in your patch and ran them with a build on jdk8/tl and the new tests you
added pass there. Maybe it is the comedy of errors that some of these
cases actually work but it would be good to get a summary.
More information about the core-libs-dev