Review Request: BigInteger patch for efficient multiplication and division (#4837946)

Brian Burkhalter brian.burkhalter at
Mon Apr 29 23:40:59 UTC 2013

On Apr 29, 2013, at 11:00 AM, Brian Burkhalter wrote:

> How much additional code is there for these two algorithms?

To answer my own question, there are apparently about 1,000 more lines.

> Unless it is some daunting amount, then if you think that the code is of sufficient quality, my opinion would be that we might as well go ahead and review the most recent version. This would take longer of course, but I think less total time than doing it in two separate passes. Also, if these are not addressed now, it could be some time before separately reviewing the other two algorithms percolated to the top of the list.
>> Let me know if there are any more questions.
> Are the patched files listed above with respect to the current tip of the JDK8 repository?

It looks to me as if they are, i.e., the only changes versus the JDK8 repo are those intended for this patch.



More information about the core-libs-dev mailing list