RFR JDK-8012645(2nd round): Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile
Alan.Bateman at oracle.com
Tue Apr 30 07:32:50 UTC 2013
On 30/04/2013 06:17, Henry Jen wrote:
> Adapt feedback from the first round, updated webrev and specdiff can be
> found at:
> Summary of change,
> 1. Javadoc change for ZipFile::stream
> 2. A inner class implements Enumeration and Iterator for
> ZipEntry/JarEntry, and the stream is now not order-significant.
> 3. Added test case for close ZipFile and JarFile to throw
I see the inner classes are protected so they will leak into the API.
The inner class is fine for ZipFile (assuming you change it to private
or package-private). For JarFile then it might be simplest to just go
back to what you had originally.
Otherwise looks okay to me.
More information about the core-libs-dev