RFR doclint issues in j.u.Deque & Queue

Martin Buchholz martinrb at google.com
Fri Aug 2 22:57:04 UTC 2013

On Thu, Aug 1, 2013 at 3:34 AM, Chris Hegarty <chris.hegarty at oracle.com>wrote:

> These changes are already committed in the jsr166 CVS, this is a request
> to pull them into jdk8.
> Specdiff has been run, and there is nothing surprising.
> The doclint issues are specifically around the addition of a caption to
> the tables, the remaining changes are cleanup, <code> -> {@code ..}, etc.
> Note: there are some minor doc updates around throwing an
> IllegalStateException if no space is currently available in Deque, which is
> already part of the spec.
Of course, I'm also happy to see the changes from jsr166 making it into

> Martin, Doug,
>  The 166 CVS is trivially missing 6546713,
> share/classes/java/util/Deque.**java.sdiff.html<http://cr.openjdk.java.net/~mduigou/6546713/0/webrev/src/share/classes/java/util/Deque.java.sdiff.html>.
> Once the changes below are in jdk8, you can easily sync with the 8 version,
> or apply the diffs from the webrev link above.
jsr166 CVS now also has these changes to Deque.java.  Although....... I am
not entirely happy about them because they create broken links if jsr166 is
built independently, i.e. not as part of openjdk, and I don't see an easy
way to fix that.  But this is one set of broken links we can just live with.

> I have already reviewed these changes, but more reviewers are welcome.

More information about the core-libs-dev mailing list