RFR: JDK-8022178: System.console() throws IOE on some Windows

Dan Xu dan.xu at oracle.com
Wed Aug 14 18:45:48 UTC 2013

Looks good to me.


On 08/14/2013 11:35 AM, Alan Bateman wrote:
> On 14/08/2013 19:35, Xueming Shen wrote:
>> Hi,
>> Please help review the trivial change for 8022178.
>> http://cr.openjdk.java.net/~sherman/console/webrev
>> System.console() is not specified to throw an IOE. It is supposed to
>> return a null silently if there is no system console or anything goes
>> wrong to get one. The Windows implementation obviously has some
>> leftover code from the old/original implementation to throw a IOE
>> if it fails to get the std in/out handler in certain use scenario. The
>> proposed change is to simply remove the IOE throwing code and
>> return silently.
> It does look like left over code, the change looks fine to me.
> -Alan

More information about the core-libs-dev mailing list