RFR [7129312] BufferedInputStream calculates negative array size with large streams and mark

Alan Bateman Alan.Bateman at oracle.com
Mon Aug 19 10:38:09 UTC 2013

On 16/08/2013 17:32, Ivan Gerasimov wrote:
> Sorry, the webrev happened to be empty.
> Here's the full one: 
> http://cr.openjdk.java.net/~igerasim/7129312/1/webrev/ 
> <http://cr.openjdk.java.net/%7Eigerasim/7129312/1/webrev/>
> Sincerely yours,
> Ivan
Thanks for taking this one.

The update to BufferedInputStream looks okay to me. I guess we don't 
actually need to check the size in the constructor, OOME will be thrown 
anyway. Usually constants are in uppercase and maybe we should just do 
this while we are here (so this means rename defaultBufferSize too).

I'm in two minds about the test as reserving 4GB of heap is going to be 
a problem on some systems (32-bit mostly).


More information about the core-libs-dev mailing list