RFR: 8021591 : (s) Additional explicit null checks

Mike Duigou mike.duigou at oracle.com
Mon Aug 19 22:15:12 UTC 2013

On Aug 1 2013, at 08:57 , Alan Bateman wrote:

> On 26/07/2013 16:31, Mike Duigou wrote:
>> Hello all;
>> This patch adds some missing checks for null that, according to interface contract, should be throwing NPE. It also improves the existing tests to check for these cases.
>> http://cr.openjdk.java.net/~mduigou/JDK-8021591/0/webrev/
>> The changes to src/share/classes/java/util/concurrent/ConcurrentHashMap.java will be synchronized separately with the jsr166 workspace. They are part of this review to avoid test failures.
>> Mike
> As retainAll and removeAll are long standing methods, are there are cases where we might now throw NPE when we didn't previously?


retainAll(null) and removeAll(null) will more consistently throw NPE. Previously the NPE was not thrown by some collections when the collection they were empty.

> I'm just wondering if any of these need to be looked at more closely, minimally to get into release/compatibility notes.

I will definitely tag this issue for release notes mention.

> -Alan

More information about the core-libs-dev mailing list