RFR (M) CR 8023234: StampedLock serializes readers on writer unlock

Martin Buchholz martinrb at google.com
Mon Aug 19 23:06:55 UTC 2013

Thanks.  Looks good.

Style suggestions for the test:

+            while(!isDone && !isInterrupted()) {
SPC after keywords.

I think it's more readable to use CountDownLatch instead of CyclicBarrier
for writerHasLock, because of asymmetric API.
Doers call countDown(), waiters call await().

On Mon, Aug 19, 2013 at 7:50 AM, Aleksey Shipilev <
aleksey.shipilev at oracle.com> wrote:

> Hi,
> This is the review for the issue originally found by Dr. Heinz Kabutz
> and Victor Grazi. The issue is consequently diagnosed and fixed by Doug
> Lea in JSR 166 CVS.
> The webrev which brings in the fix and the regression tests in JDK 8:
>    http://cr.openjdk.java.net/~shade/8023234/webrev.00/
> Testing:
>   - builds on Linux x86_64/release
>   - targeted regression test failure/pass before/after the fix
>   - java/util/concurrent/locks/StampedLock basic tests
> Thanks,
> -Aleksey.

More information about the core-libs-dev mailing list