RFR: 8016846: Pattern.splitAsStream tests required

Henry Jen henry.jen at oracle.com
Tue Aug 20 19:48:51 UTC 2013

On 07/24/2013 09:14 AM, Alan Bateman wrote:
> On 16/07/2013 12:05, Henry Jen wrote:
>> Hi,
>> Please review the webrev at,
>> http://cr.openjdk.java.net/~henryjen/tl/8016846/0/webrev/
>> The test is mostly contributed by Ben Evans.
>> Cheers,
>> Henry
> It looks okay to me, just a concern that the tests for the regex API are
> normally in test/java/util/regex.

We are using stream test framework on this to verify all style of stream
works, with that we will need to have library on bootclasspath, and that
current prevent us from put it in test/java/util/regex because of jtreg

If no object, I'll push this at its current location. We can revisit
this when jtreg support is available.

The other alternative is that we refactor the test to test only split,
and leave out the various style of stream checking. While we lose the
sanity check, but I don't think we lose much as the form of iterator
converted into stream and operated should have been covered in other
stream tests.

Let me know if we think it's important enough to refactor the test.


More information about the core-libs-dev mailing list