RFR: JDK-8023765 -- Improve MaxPathLength.java testcase and reduce its test load
Alan.Bateman at oracle.com
Tue Aug 27 07:12:51 UTC 2013
On 27/08/2013 01:18, Dan Xu wrote:
> Hi All,
> MaxPathLength.javais a troublesome testcase, and fails intermittently
> in the nightly test. And it also runs for a long time, especially on
> Windows platforms. Inorder to improve the test stability, I remove its
> unnecessary test iterations, and use NIOdelete method todo the
> clean-up to make the potential failureseasier for diagnosis. Please
> review thechanges. Thanks!
> bug: https://bugs.openjdk.java.net/browse/JDK-8023765
> webrev: http://cr.openjdk.java.net/~dxu/8023765/webrev/
The double to quickly skip over the names to MAX_LENGTH/2 looks reasonable.
I guess fileCreated should really be fileExists as it may be deleted and
then deleted. An alternative here would be to use Files.deleteIfExists
as that would avoid the need to introduce flags to track whether the
directory and exist exists.
More information about the core-libs-dev