RFR JDK-8023713: ZipFileSystem has compatiable issue to handle old zip file.

Xueming Shen xueming.shen at oracle.com
Wed Aug 28 16:29:45 UTC 2013

On 08/28/2013 03:56 AM, Alan Bateman wrote:
> On 28/08/2013 00:09, Xueming Shen wrote:
>> On 08/27/2013 03:07 PM, Martin Buchholz wrote:
>>> It does seem vaguely reasonable to support any extra data.
>>> Don't you want to also handle arbitrary byte arrays, if e.g. one the 16-bit size fields overflows the extra data?
>>> It looks to me like getExtraLen could return a negative number.
>> probably I should. The webrev has been updated to simply
>> copy the rest of the extra data, if the "sz" is either < 0 or
>> out of the range.
>> http://cr.openjdk.java.net/~sherman/8023713/webrev/
> The updated webrev looks okay, just odd to see an entry named " TestExtreTime" (which may have been a continuation of a typo in the original test).

Thanks Alan! That was indeed a typo:-) fixed in updated webrev.


More information about the core-libs-dev mailing list