RFR 8004547: Extend JavaFX launcher support...

David DeHaven david.dehaven at oracle.com
Fri Jan 4 17:46:59 UTC 2013

[pardon the data shuffle…]

>>>> Cmd line                   FAC             LAUNCH_MODE JAVAFX_LAUNCH_MODE
>>>> java -jar fxapp.jar        Present         LM_JAR       LM_JAR
>>>> java -jar fxapp.jar        Not present     LM_JAR       [LM_JAR]
>>>> java -cp fxapp.jar ...     Not present LM_CLASS            LM_CLASS
>>>> java -cp somedir ...       Not present LM_CLASS            LM_CLASS

> It is looking good, a couple of comments and requests:
> 1. LauncherHelper.java: Can you please document the table below in
>    LauncherHelper.java, and a note to refer to LauncherHelper.java in
>    FXLauncherTest.java this will make it easier to understand everything
>    in the future.

Can do.

> 2. FXLauncherTest.java
> a. testExtraneousJars, you have changed the cmd from javac to java
>    using a java class, thus this error message is not accurate:
> throw new Exception("jfxrt.jar is being loaded by javac!!!");

Will fix the error message.

> b. The case of -jar with no JAC is being commented out ? I take it this
>    is redundant now ? Does this need to present ? or a todo for later ?
>   If so please comment it appropriately.
>   // Todo: blah
>   // testBasic......
>   or
>   /*
>    * Redundant but can be used iff .....
>    * .......
>    */

That's what my final comment was about in my email:

>> I had commented out two tests, but FX is in sync with JDK *and* they'll pass vacuously until FX is on the ext classpath anyways so I don't think that's necessary.

I've uncommented them since it should be fine as long as the corresponding FX change gets into the same promotion.


More information about the core-libs-dev mailing list