RFR 8004547: Extend JavaFX launcher support...

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Sat Jan 5 01:01:59 UTC 2013

On 1/4/2013 3:10 PM, David DeHaven wrote:
>>>>>>>> Cmd line                   FAC             LAUNCH_MODE JAVAFX_LAUNCH_MODE
>>>>>>>> java -jar fxapp.jar        Present         LM_JAR       LM_JAR
>>>>>>>> java -jar fxapp.jar        Not present     LM_JAR       [LM_JAR]
>>>>>>>> java -cp fxapp.jar ...     Not present LM_CLASS            LM_CLASS
>>>>>>>> java -cp somedir ...       Not present LM_CLASS            LM_CLASS
>>> I didn't see any reliable means of testing the last case without further changes to TestHelper.java, is it that important? The code path through LauncherHelper.java should be the same for either -cp case. I can add the test case if it's important, but that will require changes to TestHelper.java to allow compiling to a directory without creating a jar file.
>> -cp fxapp.jar should be sufficient for this, this is more sensitive to the launcher itself,
>> and is tested thoroughly in Arrrghs.java and elsewhere.
> In that case, the only changes I have are the changes you requested earlier. If there are no further objections can we call this done?
I approve the change with the following adjustments.

small nit indenting....

+     * java -cp fxapp.jar MainClass N/A               LM_CLASS     LM_CLASS

actually I prefer the that table in LauncherHelper.java in the FXHelper 
inner class
I don't need to see another webrev only for this.

> Latest webrev:
> http://cr.openjdk.java.net/~ddehaven/8004547/webrev.3/
> -DrD-

More information about the core-libs-dev mailing list