RFR: 8005466 zip_util.h

Ioi Lam ioi.lam at oracle.com
Wed Jan 9 19:05:50 UTC 2013

Please review:

http://cr.openjdk.java.net/~coleenp/8005466_zip_util_001/  <http://cr.openjdk.java.net/%7Ecoleenp/8005466_zip_util_001/>

bug: JAR file entry hash table uses too much memory (zip_util.c)


This submission is just a one-liner fix that changes 64-bit structure
member alignment. The savings are only half as noted in the original
bug description, but still significant:

     HelloWorld: about 150KB.
     Eclipse: about 540KB.

This benefits all 64-bit VMs, as well as 32-bit VMs that are built with
ABIs that require 8-byte structure alignment for jlong (e.g., as ARM EABI).

(I have another fix that would reduce memory usage further, but it's
  too risky now and I may wait till JDK9).

Repository used:

I usedhttp://hg.openjdk.java.net/hsx/hotspot-rt/. Not sure if this is the
right repo to use.

Tests run:

+ JPRT -- To verify build-ability; JPRT also runs jtreg jdk/tools tests
           on all platforms. This includes basic JAR file tests.

+ Manually ran UTE/vm.quick.testlist on Linux/x64


More information about the core-libs-dev mailing list