RFR (XS): CR 8004330: Add missing Unsafe entry points for addAndGet() family
chris.hegarty at oracle.com
Wed Jan 9 21:17:12 UTC 2013
On 20 Dec 2012, at 19:21, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> Looks good for me. I will sponsor these changes after we get a review from JDK side.
Have I missed something, or are these changes not already in?
> On 12/20/12 11:03 AM, Aleksey Shipilev wrote:
>> Sorry for cross-list posting, but this change affects both HS and JDK.
>> This simple change is missing from recently committed CR 7023898. While
>> the VM support is there in Hotspot, no methods are exposed in Unsafe to
>> actually make use of those intrinsics. This is the webrev fixing that:
>> It turns out the getAndSet intrinsics HotSpot are overloaded, which had
>> deluged both Doug and me in the previous patch. These namings are
>> inconsistent with other Unsafe intrinsic naming convention, so this
>> change fixes that as well.
>> - Built and tested in Linux x86_64
>> - java-concurrency-torture  atomicity tests are passed for
>> AtomicIntegerV8  and AtomicLongV8  making use of those intrinsics
>> on Linux x86_64
>> - running the java-concurrency-torture tests "-XX:+PrintInlining |
>> grep Unsafe" tells all intrinsics have been successfully inlined
>> - no other testing is expected for this trivial change.
>> I would need a sponsor to push this. Thanks for your patience and reviews!
>> - dl: original patch, testing
>> - shade: due diligence, messing with reviews, tests, and rebuilds
>>  https://github.com/shipilev/java-concurrency-torture/
More information about the core-libs-dev