review request 8006139, add missing methods to javax.sql.rowset.serial.SQLInput/OutputImpl

Ulf Zibis Ulf.Zibis at
Sun Jan 13 10:56:06 UTC 2013

Am 12.01.2013 22:56, schrieb Lance Andersen - Oracle:
> Hi
> This is a review request for 8006139 which adds missing methods to SQLInput/Output
> The webrev can be found at


are you paid by code lines ;-)
Additionally you have left out one opportunity
... or is it new code style, having 2 wrong indented closing braces in one line?

I would code:

  811     public String readNString() throws SQLException {
  812         String attrib = (String)getNextAttribute();
  813         lastValueWasNull =attrib == null;
  814return attrib;
  815     }

Additionally I'm wondering, whether getNextAttribute() could be generified.


More information about the core-libs-dev mailing list