Review request: JDK-8021245 (process) file leak in jdk/src/windows/native/java/lang/ProcessImpl_md.c
Alan.Bateman at oracle.com
Sun Jul 28 17:40:07 UTC 2013
On 26/07/2013 08:33, Alexey Utkin wrote:
> Bug description:
> Here is the suggested fix:
> In accordance with MS spec [-1] is THE ONLY error signal from the
> [_open] function call.
> Any negative, except [-1], and zero are the valid handles that need to
> be closed.
> The fix was tested in the debugger my manual switching to Win9x/WinMe
> brunch of execution.
Checking if _open returns -1 and checking the return from _read and
_lseek/_read looks okay to me. My only comment is that the "if (" on its
own looks a bit odd, I just I would at least hoist the first part of the
expression onto the same line.
More information about the core-libs-dev