RFR 8010325 : Remove hash32() method and hash32 int field from java.lang.String
sean.coffey at oracle.com
Wed Jun 12 21:12:16 UTC 2013
do you need to remove the sun/misc/Hashing.java reference from the
make/java/java/FILES_java.gmk file? I suspect it could break builds for
people still using the old build system on jdk8.
On 12/06/13 17:30, Brent Christian wrote:
> Thanks for the reviews, everyone. I will change the nits mentioned.
> And I need a sponsor.
> On 6/12/13 9:10 AM, Mike Duigou wrote:
>> Looks good to me.
>> On Jun 11 2013, at 13:32 , Brent Christian wrote:
>>> Please review my fix for 8010325. Some background:
>>> The alternative string-hashing implementation added to
>>> java.lang.String a new public method, hash32(), as well as a new
>>> private int field to cache the alternate hash value.
>>> Following 8005698  and 8005704 , the new method and field in
>>> String are no longer used.
>>> By updating a couple lines in Hashtable/HashMap/WeakHashMap, the
>>> internal sun.misc.Hashing class can also be removed.
>>> The webrev is here:
>>> 1. http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/43bd5ee0205e
>>> 2. http://bugs.sun.com/view_bug.do?bug_id=8005698
>>> 3. http://bugs.sun.com/view_bug.do?bug_id=8005704
More information about the core-libs-dev