Code Review Request: 8016698: Cleanup overrides warning in sun/tools/ClassDeclaration.java
Alan.Bateman at oracle.com
Sat Jun 15 06:56:49 UTC 2013
On 14/06/2013 23:59, Kurchi Hazra wrote:
> This is to elimnate the overrides warning from ClassDeclaration.java.
> This class is used by rmi, but sun/tools/java and
> sun/tools/javac also heavily uses it, let me know if anyone else
> should also be reviewing it.
> Bug: http://bugs.sun.com/view_bug.do?bug_id=8016698 [To appear]
> Webrev: http://cr.openjdk.java.net/~khazra/8016698/webrev.00/
This looks okay for the purposes of squashing the warning but the
existing equals method does look suspect. It might not matter for the
rmic usage but as the equals doesn't take account of the the
"definition" then it looks to me that it consider very different
ClassDeclarations as equals. It would be good to understand how it is
used to see whether we have an issue here or not.
More information about the core-libs-dev