JDK-8016285: Add java.lang.reflect.Parameter.isNamePresent()
aleksey.shipilev at oracle.com
Mon Jun 24 21:28:46 UTC 2013
Forgot to reply: I'm ok with webrev.01.
(rural r reviewer)
On 06/24/2013 11:20 PM, Eric McCorkle wrote:
> Pinging this RFR. It still needs a capital R reviewer.
> On 06/21/13 19:21, Eric McCorkle wrote:
>> On 06/21/13 16:15, Aleksey Shipilev wrote:
>>> On 06/21/2013 11:57 PM, Eric McCorkle wrote:
>>>> The webrev is here:
>>> Looks generally good (but not a Reviewer).
>>> A few questions though:
>>> a) Are we em-bracing the brace-less control flow blocks?
>> Fixed it.
>>> b) Should hasRealParameterData be transient?
>>> c) Should hasRealParameterData be volatile? (now is being implicitly
>>> protected by $parameters volatile write/read, but it is fragile)
>> Transient yes. Volatile, I'd say I think not, since It's written before
>> it's read on all possible paths, and all writes are the same value.
>> But... I set it volatile just to be safe from reordering problems.
>> Webrev's been updated.
More information about the core-libs-dev