Define JNIEXPORT as visibility default with GCC?
martinrb at google.com
Mon Mar 11 23:57:02 UTC 2013
The latest version of my webrev is here:
It includes this line:
Reviewed-by: coleenp, ddehaven, dcubed
Ok to push?
On Fri, Mar 8, 2013 at 10:31 AM, Coleen Phillmore <
coleen.phillimore at oracle.com> wrote:
> The hotspot definitions of JNIEXPORT don't match in all the files to the
> JDK definition. I think a hotspot bug should be filed to fix the
> jni_<cpu>.h definitions which now none of them match. After someone in
> core-libs checks this in, we'll update the hotspot files to match the final
> version and retest -fvisibility=hidden.
> I don't remember why the JDK version wasn't fixed with the original
> -fvisibility=hidden work.
> On 2/28/2013 3:56 PM, Daniel D. Daugherty wrote:
>> On 2/28/13 11:57 AM, David DeHaven wrote:
>>> Has a bug been filed for this? -DrD-
>> As mentioned earlier in this thread...
>> On 2/19/13 5:21 PM, Daniel D. Daugherty wrote:
>>> I couldn't find a 'jdk' repo relevant bug for this issue so I filed:
>>> 8008509: 6588413 changed JNIEXPORT visibility for GCC on HSX, jdk's
>>> jni_md.h needs similar change
>>> Coleen did the original work on 6588413 so I added her to the "interest
>>> list" for the new bug. The need for an update to the jdk repo's jni_md.h
>>> file was raised during the code review for 6588413, but that detail
>>> to have been dropped.
More information about the core-libs-dev