Review Request: JDK-8001334 - Remove use of JVM_* functions from java.io code
alexey.utkin at oracle.com
Wed Mar 13 11:10:34 UTC 2013
On 12.03.2013 3:43, Dan Xu wrote:
> Thanks for all your comments. I have updated the fix accordingly.
> Please see the webrev at
> For the language concern in getLastErrorString(char *buf, size_t len)
> function, I will log another bug and address it later. Thanks!
Ok. That is a common place for Windows platform: you got a problem each
time you are using ASCII API with Java. I spent some time while
resolving that kind of problems in Java deployment.
> On Thu 07 Mar 2013 05:28:15 AM PST, Alan Bateman wrote:
>> On 07/03/2013 13:21, Alexey Utkin wrote:
>>> Can I say two word about the file
>>> and function
>>> getLastErrorString(char *buf, size_t len)
>>> Here is the documentation for [FormatMessage]:
>>> if you are using ASCII version of FormatMessage that is a good idea
>>> to have the direct reference to [FormatMessageA], not define.
>>> The second word is about the third world countries: Russia and China.
>>> Windows OS has localized version. The error messages on that systems
>>> would contains only [?] in the worst case.
>> It's good to re-examine this but just to mention that this is just
>> bringing over what is in os::lasterror (in
More information about the core-libs-dev