martinrb at google.com
Fri Mar 22 14:19:20 UTC 2013
On Thu, Mar 21, 2013 at 12:11 PM, Christos Zoulas <christos at zoulas.com>wrote:
> On Mar 21, 11:36am, john.zavgren at oracle.com (John Zavgren) wrote:
> -- Subject: Re: RFR-8008118
> | All:
> | How does this look?
> | 1.) I reverted the for statement formatting change.
> Not exactly. Now it is indented incorrectly.
Agreed. Really revert.
> | 2.) I removed the goto statement and "inlined" some code instead.
> I prefer to write simpler code that works with both signed and unsigned
> + while (i > 0)
> + if (pathv[--i] != cwd)
> + free(pathv[i]);
Christos' suggestion looks pretty good.
As Mark noted, need to add missing free of pathv itself.
> | 3.) I checked to make sure that we're not freeing memory that we didn't
> | ually allocate. (Path vector elements that are empty.)
> You are still using the "./" string literal constant in the code so you'll
> end up freeing it (the compiler will prolly merge the two instances and
> you'll get lucky but it is semantically incorrect).
pathv[i] = cwd;
More information about the core-libs-dev