JDK-8011653: Upgrade to JAXP 1.5

Alan Bateman Alan.Bateman at oracle.com
Fri May 3 14:49:21 UTC 2013

On 03/05/2013 09:01, huizhe wang wrote:
> Hi Alan, Lance,
> This is an update that reflects the spec change, and also fixes for 
> JDK-8013232 and JDK-8013484.
> Please review:
> http://cr.openjdk.java.net/~joehw/jdk8/8011653/webrev/
I've read through the javadoc/spec changes.

One comment is that there is a lot of repetition. The syntax of the 
property value is defined in no less than 9 places. At least for the 
setAttribute methods, then couldn't these just reference the properties 
in XMLConstants?

One suggestion for

"Default value: implementations shall decide whether to restrict 
connection by default ...." and the options list.

is to replace it with:

"The default value is implementation specific and therefore not 
specified. Implementations are highly recommend to restrict external 
connections by default when FEATURE_SECURE_PROCESSING is set to true."

For ACCESS_EXTERNAL_DTD then this statement isn't clear:

"Restrict access to external DTDs, external Entity References to the 
protocols specified."

Should "external Entity References" be dropped here, or "," replaced 
with "and"?


More information about the core-libs-dev mailing list