Review Request for JDK-8003992: File and other classes in do not handle embedded nulls properly

Florian Weimer fweimer at
Mon May 6 13:59:49 UTC 2013

On 05/03/2013 01:08 AM, Dan Xu wrote:
> Hi All,
> Thanks for all your comments. Based on the previous feedback, I have
> moved to the other approach, i.e., to fail file operations if the
> invalid NUL characher is found in a file path. As you know, due to the
> compatibility issue, we cannot throw an exception immediately in the
> File constructors. So the failure is delayed and only shown up when any
> file operation is triggered.
> As for FileInputStream, FileOutputStream, and RandomAccessFile classes,
> the FileNotFoundException will be thrown right away since their spec
> allow this exception happen in the constructors. Thanks for your review!
> webrev:

I like this approach, thanks.

I think the additional parenthesis around the return expression and the 
ternary operator are not part of the usual coding standard.

Florian Weimer / Red Hat Product Security Team

More information about the core-libs-dev mailing list