Request for Review 8014296: DivModTests should not compare pointers
joe.darcy at oracle.com
Fri May 10 15:39:04 UTC 2013
Good to push.
On 05/10/2013 08:25 AM, roger riggs wrote:
> Thanks, the webrev now has the correct copyright change.
> On 5/10/2013 11:14 AM, Joe Darcy wrote:
>> On 05/10/2013 08:02 AM, roger riggs wrote:
>>> Please review this minor correction to DivModTests to address this
>>> With autoboxing of mixed types primitive and Object, the operators
>>> == and !=
>>> are interpreted as reference compare instead of value compares.
>>> The compiler is silent about the likely unintended consequences.
>>> Thanks, Roger
>> The copyright range should now be "2012, 2013,".
>> Otherwise, the change looks fine.
More information about the core-libs-dev