RFR 6303183: Support NTFS and Unix-style timestamps for entries in Zip files

Xueming Shen xueming.shen at oracle.com
Wed May 29 22:17:35 UTC 2013

Hi Martin,

Somehow most of your comments are "blank lines" in my mailbox, just wonder if
you can send them again. Based on the "hints", I updated those javadoc comments
in ZipUtils to "**".

The code has been updated slightly (mainly to not output the extra time stamp if
it already exists in the passed in/read in/user defined "extra' field. I added a test
TestExtraTime to test couple use scenario and also updated couple existing tests
(which depend on the hard coded extra field size...).

Now all unit/regression tests are passed.


As we discussed in other thread, I will continue to see the possibility of adding
atime/ctime support and better time granularity (via NTFS extra field).


On 05/28/2013 08:36 PM, Martin Buchholz wrote:
> Looks good to me.
> ---
> While you're moving code around, you could fix the typo below and change method comments to javadoc style ('*' => '**'')
> accidnetly
> and

More information about the core-libs-dev mailing list