RFR (jaxp): Backport to jdk7u-dev of 8013900: More warnings compiling jaxp.
chris.hegarty at oracle.com
Fri May 31 08:20:55 UTC 2013
On 05/30/2013 06:30 PM, huizhe wang wrote:
> On 5/30/2013 9:22 AM, Chris Hegarty wrote:
>> Looks fine to me Daniel,
>> I see you have three copies of Objects.java, is it possible to put it
>> in a common place accessible to all? Or maybe this causes other issues.
> JAXP consists of multiple components. The Xerces and Xalan components
> specifically are by their own and do not have references across the
> boundaries. Our next project is modularization in which Xerces and Xalan
> will definitely be split into difference modules. As for BCEL, since
> it's always by itself, it's preferable to let it that way, unless it
> really affects footprint.
No problem Joe, this addresses my concerns.
>> On 05/30/2013 11:37 AM, Daniel Fuchs wrote:
>>> This is a request for review of the backport of
>>> to jdk7u-dev.
>>> The changeset for jdk7u-dev  had to be altered on one count
>>> compared to the changes pushed in jdk8 :
>>> Since jaxp needs to be compiled using the bootstrap
>>> compiler, it was not possible to use the new
>>> JDK 7 java.util.Objects API.
>>> In order to minimize the changes between the two
>>> changesets - I added an Objects class emulating
>>> the two 'hashCode' and 'equals' methods of java.util.Objects
>>> in the util packages of Xerces, Xalan, and Bcel.
>>> This way - the only thing that needed to change in the rest of
>>> the files was the import clause of the Objects class.
>>> Here is the altered changeset for jdk7u-dev:
>>> Here is the changeset that was pushed in jdk8:
>>>  <http://cr.openjdk.java.net/~dfuchs/JDK-8013900/webrev.01/>
>>> -- daniel
>>> Review for the original jdk8 changeset  happened on core-libs-dev:
More information about the core-libs-dev