Proposed fix for JDK-8028804 (Deflater.deflateBytes() may produce corrupted output on Deflater level/strategy change)
Alan.Bateman at oracle.com
Thu Nov 28 19:29:05 UTC 2013
On 27/11/2013 08:33, Thomas Stüfe wrote:
> I can see arguments for both sides (linking statically vs using the
> system zlib) and I'm leaning toward the former. Errors or
> incompatibilities in the zlib could be really harmful, and I rather
> use the zlib I ran all my tests with instead of the system zlib which
> may or may not be out of date or show regressions.
Statically linking has its advantages when you are creating a binary
that needs to run on many distributions. However, I think we have to
allow for anyone to link against the system zlib. I believe it might
even be a hard requirement for many of the Linux distributions (there
are folks from the IcedTea project on this list that will know a lot
more about that topic).
> So, if I were to recode this fix again to not change the zlib - which
> is not so trivial - do you think there is a chance that this fix gets
> examined and maybe pulled into the OpenJDK?
I don't see any reason why not. So I would suggest go ahead and see if
this can be fixed without changing zlib. If you can come up with a patch
then bring it here and we can review/discuss it.
More information about the core-libs-dev