RFR: 8920687: Deflater.setLevel does not work as expected

Xueming Shen xueming.shen at oracle.com
Sun Sep 15 20:22:02 UTC 2013

Updated accordingly.



On 9/15/13 12:45 PM, Alan Bateman wrote:
> On 15/09/2013 19:30, Xueming Shen wrote:
>> Thanks Alan. I dropped the "current" in setLevel. Yes, I would like 
>> to be explicit about the
>> deflate invocation here, as the implementation clearly just calls the 
>> deflate() blindly with
>> the old level/strategy after the level/strategy changed, regardless 
>> whether there is really
>> anything in the buffer or not. So I think it might be good to set the 
>> expectation clear here.
>> http://cr.openjdk.java.net/~sherman/8020687/webrev/
>> -Sherman
> This is okay, the only thing is the words "of deflate methods" is a 
> bit odd. Do you want to change this to simple "deflate"?
> -Alan.

More information about the core-libs-dev mailing list