review request 7097386: Correct error in Predicate javadoc example
aleksey.shipilev at oracle.com
Mon Sep 16 08:58:15 UTC 2013
On 09/15/2013 10:38 PM, Lance Andersen - Oracle wrote:
> I added a webrev
> http://cr.openjdk.java.net/~lancea/7097386/webrev.00/ as it might be
> a bit easier for this review.
- change C-style "int v" declarations to Java-ish "int v".
- catching SQLException should probably return "false" right away?
- "if" block can float up to the exception handler block, eliminating
the need for "int value = 0" line.
Otherwise, looks good (not a Reviewer).
More information about the core-libs-dev