JDK 9 RFR of JDK-8035076: Pattern$BnMS never used due to bug in Pattern$BnM.optimize
Alan.Bateman at oracle.com
Thu Feb 20 08:21:55 UTC 2014
On 19/02/2014 22:31, Xueming Shen wrote:
> Please help codereview the change for JDK-8035076.
> Issue: https://bugs.openjdk.java.net/browse/JDK-8035076
> Webrev: http://cr.openjdk.java.net/~sherman/8035067/webrev
> This is regression caused by the change we made back to jdk7 to
> support case
> insensitive match, in which a base class SliceNode for Slice family
> was added and
> we mistakenly subclass the SliceS class to this newly added class,
> instead of
> the original Slice class. The BnM optimization for supplementary
> support, which
> is based on the "instanceof Slice", is therefor disabled.
I wonder if the submitter observed a performance regression or whether
it was just observed by reading the code. In any case, it looks good to me.
More information about the core-libs-dev