RFR 9: 8003488 Add Process.getPid
roger.riggs at oracle.com
Thu May 22 19:47:56 UTC 2014
Thanks for the feedback and recommendations; the webrev has been updated.
Alan, on the use of tasklist, I think a cleaner test can be written when the
Java API to inspect other processes is available. I did not find a
eqivalent for $$; there is a possible hack using tasklist but it would
be a throwaway.
On 5/22/2014 11:01 AM, Alan Bateman wrote:
> On 22/05/2014 14:49, roger riggs wrote:
>> The webrev has been updated to more completely describe the pid:
>> "The native process id is an identification number that the operating
>> system assigns to the process."
>> Any other comments?
>> Webrev: http://cr.openjdk.java.net/~rriggs/webrev-getpid-8003488/
> Roger and I discussed this one last week so I'm happy with the
> signature and javadoc.
> I see Ivan has picked up on the HANDLE <--> jlong and jlong_to_ptr is
> normally the macro that we use for that.
> A minor consistency point is that the getPid is added before the
> constructor whereas the other overrides are below the constructor.
> For the test then it would be good to add the issue number to the @bug
> One question on the test as I'm not familiar with output of tasklist.
> If 2+ test were to run tasklist at the same time then could it confuse
> this test? I'm just wondering if there is anything closer to echo $$.
> Otherwise looks good to me.
More information about the core-libs-dev