Review request for XML JAXP unit test colocation
tristan.yan at oracle.com
Thu Nov 6 03:41:14 UTC 2014
What I meant is uploading webrev for you. An open JDK review means you send your code to open JDK alias. Anyone is open JDK alias is eligible to review your code. There are some people they are not working on Oracle. They have no access to Oracle network. According the open JDK process your webrev has to be uploaded into somewhere that everyone can access. Most of people are using cr.openjdk.java.net <http://cr.openjdk.java.net/> because this is provided to people who has Author/Role in open JDK community. I can’t create an account for you. You need contribute before you get an open JDK id. Please see the detail information as following link.
> On Nov 5, 2014, at 7:03 PM, Frank Yuan <frank.yuan at oracle.com> wrote:
> Oh, thanks for your reminder!
> Do you mean you can help me to generate an account to access cr.openjdk.java.net <http://cr.openjdk.java.net/>? Certainly I want, thanks in advance.
> Best Regards
> From: Tristan Yan [mailto:tristan.yan at oracle.com]
> Sent: Thursday, November 06, 2014 3:54 AM
> To: Frank Yuan
> Cc: Core Java Libraries SQE
> Subject: Re: Review request for XML JAXP unit test colocation
> Hi Frank
> I think you’re using internal link for open review. You need a standard one in cr.openjdk.java.net <http://cr.openjdk.java.net/>. Do you want me to help you to generate one?
>> On Nov 5, 2014, at 1:12 AM, Frank Yuan <frank.yuan at oracle.com <mailto:frank.yuan at oracle.com>> wrote:
>> Hi, Joe and All
>> Thanks for your previous reviews and comments. Per your comments: I added
>> description for every test, got them running with and without security
>> manager and fixed the known test issues. Could you help review the changes
>> for JAXP unittest co-location again? After your review, I will push the
>> tests into JDK repo: jaxp/test.
>> bug: https://bugs.openjdk.java.net/browse/JDK-8043090 <https://bugs.openjdk.java.net/browse/JDK-8043090>
>> webrev: http://sqeweb.us.oracle.com/jsn/users/yc/webrev/ <http://sqeweb.us.oracle.com/jsn/users/yc/webrev/>
>> test results:
>> http://sqeweb.us.oracle.com/jsn/users/yc/result/JTreport/html/index.html <http://sqeweb.us.oracle.com/jsn/users/yc/result/JTreport/html/index.html>
More information about the core-libs-dev