RFR: 8060132: Handlers configured on abstract nodes in logging.properties are not always properly closed

Mandy Chung mandy.chung at oracle.com
Fri Nov 7 06:42:39 UTC 2014

On 11/5/2014 8:15 AM, Daniel Fuchs wrote:
> Here is the new webrev:
> http://cr.openjdk.java.net/~dfuchs/webrev_8060132/webrev.03/index.html 

Looks good.  Minor nits and no need to generate new webrev.

line 108: {@linkplain #reset} -- # is missing.
line 918-921: nit: formatting looks a little inconsistent with the code 
around it.
Perhaps better to wrap them in 2 lines:

boolean ensureCloseOnReset = names.length > 0  &&
     getBooleanProperty(handlersPropertyName + ".ensureCloseOnReset",  true);


More information about the core-libs-dev mailing list