RFR (S) 8059677: Thread.getName() instantiates Strings

Staffan Larsen staffan.larsen at oracle.com
Tue Nov 11 08:03:18 UTC 2014

I was able to provoke the failure with a “jstack -F”. I think this patch solves the problem: http://cr.openjdk.java.net/~sla/8059677-thread.name.sa.patch <http://cr.openjdk.java.net/~sla/8059677-thread.name.sa.patch>. Feel free to not include the changes in StackTrace.java if you don’t want to complicate your review.


> On 10 nov 2014, at 19:09, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> On 10.11.2014 19:39, Staffan Larsen wrote:
>>> On 10 nov 2014, at 15:55, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
>>> Ow, it seems very like it.
>>> So, what testlist have I missed to catch this?
>> Probably vm.tmtools.testlist and/or nsk.sajdi.testlist. Just a warning that these tests are far from stable. Sorry about that.
> Alas, both these testlists pass with current change without a hitch.
> That probably tells something about the test coverage. Any other ideas
> how to test for it? Maybe some manual way?
> Anyhow, there is a synonymous block in ThreadGroup handling, I can copy
> the relevant bits from there. Updated webrev follows soon. Still need to
> test if that change is safe.
> -Aleksey.

More information about the core-libs-dev mailing list