Review request: JDK-8055723 Replace concat String to append in StringBuilder parameters

Wang Weijun at
Thu Nov 13 01:19:31 UTC 2014

I hope we can restrict the code change to what the bug description is about. IMHO this bug should only include cleanup and introduce no obvious behavior change.

Any other fix can go to another bug.


> On Nov 13, 2014, at 08:57, Otávio Gonçalves de Santana <otaviojava at> wrote:
> But this class is an Exception, doesn't make sense an exception get another
> Exception.
> IMHO: I prefer this way
> On Wed, Nov 12, 2014 at 8:36 AM, Ulf Zibis <Ulf.Zibis at> wrote:
>> Hi Otávio,
>> I now think you could replace
>>         if (!expected.isEmpty())
>> with
>>         assert !expected.isEmpty();
>> If expected ever would be empty, the only thing which happens is, that a
>> "'" is missing in a message which anyway doesn't make sense without
>> arguments.
>> -Ulf

More information about the core-libs-dev mailing list