RFR: 8059570, Addition of tests for RowSetFactory and RowSetProvider
lance.andersen at oracle.com
Thu Oct 2 11:08:09 UTC 2014
Thank you for you review.
On Oct 2, 2014, at 6:39 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> Hi Lance,
> I probably don't know enough about rowset to qualify as reviewer
> for this change, but I had a look at the tests - and I believe
> they look good.
> I wonder whether there should be some additional tests that would
> run with a security manager on?
There are tests elsewhere which run with a SecurityManager. I might add some here later but will be in a different test file
> The only thing unusual I noticed is that the jars seem to have a
> .DS_Store in their META-INF ;-)
thanks, deleted that. Have hidden files enabled on my mac and forgot to remove it.
> best regards,
> -- daniel
> On 01/10/14 19:55, Lance Andersen wrote:
>> Hi all,
>> Looking for a reviewer for the unit tests being added for RowSetFactory and RowSetProvider.
>> The webrev can be found at http://cr.openjdk.java.net/~lancea/8059570/webrev.00/
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
More information about the core-libs-dev