RFR(L): JDK-8057777 Cleanup of old and unused VM interfaces
Alan.Bateman at oracle.com
Fri Oct 3 15:19:43 UTC 2014
On 30/09/2014 07:40, Frederic Parain wrote:
> Hi all,
> Please review changes for bug JDK-8057777 "Cleanup of old
> and unused VM interfaces"
> This is basically a big cleanup of VM interfaces that are
> not used anymore by the JDK but have been kept in our code
> base for historical reasons (HotSpot Express for instance).
> These changesets remove these interfaces from both the
> JDK and the HotSpot side, and also perform some cleanup
> on code that directly referenced the removed interfaces.
> These changes do not modify the behavior of the Java
> classes impacted by the cleanup.
> VM interfaces removal has been approved by CCC and
> a Release Note has been prepared that explicitly list
> all the removed interfaces.
> Testing: JPRT hotspot + core, vm.quick.testlist, jdk_core
cc'ing core-libs-dev as part of this is clean-up in the library code too.
I think we should deprecate java.lang.Compiler and the Runtime.traceXXX
methods. They've been non-functional for a long time and having them in
the API is a bit mis-leading to anyone reading the javadoc. I realize
you are focused on the removing the old JVM_* functions so we can
follow-up on that via other issues of course.
Can ClassLoader#resolveClass0 can be removed completely? The null check
can be done in ClassLoader#resolveClass.
In the mapfile for libjava then the comment at line 281 says "ZipFile.c
needs this one". As getLastErrorString is now exported for use by libzip
then the comment should probably be updated.
Otherwise this clean-up looks good to me and the jdk_core group of tests
is the right group to exercise this area.
More information about the core-libs-dev