RFR : (proxy) sun.misc.ProxyGenerator.generateProxyClass should create intermediate directories
mandy.chung at oracle.com
Wed Oct 8 19:22:45 UTC 2014
On 10/7/2014 1:47 AM, Ivan Gerasimov wrote:
> Thank you Mandy!
> I've updated the webrev based on your suggestions.
> The test is moved to test/sun/misc/ProxyGenerator/ directory.
> Here's the updated webrev:
Thanks for updating the test. Nit: I suggest to remove the directory
"a" at the beginning rather than throwing a RuntimeException so that you
can run the test multiple times manually.
> Sincerely yours,
> On 07.10.2014 9:47, Mandy Chung wrote:
>> On 10/6/2014 4:35 AM, Ivan Gerasimov wrote:
>>> This is a 7u-only fix.
>>> Some users complain about the ProxyGenerator not creating the
>>> intermediate directories when asked to keep the generated files.
>>> It throws an IO exception instead
>>> The fix is essentially a part of JDK-8004260.
>>> That was a relatively big update, which required CCC, so it's not
>>> feasible to port it as a whole.
>>> Would you please help review it?
>>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8059563
>>> WEBREV: http://cr.openjdk.java.net/~igerasim/8059563/0/webrev/
>> The fix looks okay.
>> Typo in the new test line 26: s/intermidiate/intermediate. It would
>> be good to make sure the directory doesn't exist before generating
>> the proxy class and also check if the expected file is created after
>> it's generated. An alternative is to call Proxy.getProxyClass
>> instead ProxyGenerator as your test is under
>> java/lang/reflect/Proxy. Maybe the testname be renamed to
More information about the core-libs-dev