RFR 8058854: Remove dependency on dt.jar from test/tools/jar/normalize/TestNormal.java

Amy Lu amy.lu at oracle.com
Mon Oct 13 13:58:22 UTC 2014

On 10/13/14, 4:57 PM, Chris Hegarty wrote:
> I'm not sure that it matters, in the context of this test, but the jar 
> file being created will now contain a much smaller number of entries 
> than was previously being tested.  I have a similar comment about the 
> previous cleanup too.
> I wonder if we need functionality in the testlibrary to create 
> relatively substantial jar files to test with? Or maybe the number of 
> entries has no great impact on some tests.
The number of entries should not have great impact on these tests...But 
having a testlibrary for creating small/big jar for test would be good 
enhancement in the next milestone.


> -Chris.
> On 13/10/14 09:47, Alan Bateman wrote:
>> On 13/10/2014 09:23, Amy Lu wrote:
>>> tools/jar/normalize/TestNormal.java use JDK dt.jar in test, this fix
>>> is to remove this dependency from test because with a modular dt.jar
>>> and the other JAR files in the JDK go away.
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8058854
>>> webrev: http://cr.openjdk.java.net/~tyan/amylu/8058854/webrev.00/
>> I'm not sure about @library ../../pack200 and using the pack200 test
>> support as it created a non-obvious dependency in the test tree. An
>> alternative would be to move the test to the pack200 test directory as
>> this test is about create JAR files that invariant to pack200 
>> operations.
>> -Alan.

More information about the core-libs-dev mailing list