RFR JDK-6321472: Add CRC-32C API

Ulf Zibis Ulf.Zibis at CoSoCo.de
Fri Oct 17 19:56:17 UTC 2014

Am 17.10.2014 um 20:58 schrieb Staffan Friberg:
> Here is a new webrev with the updates from Alan's and Peter's suggestions.
>     http://cr.openjdk.java.net/~sfriberg/JDK-6321472/webrev.01

I would not remove:
   86     public void update(byte[] b) {
   87         adler = updateBytes(adler, b, 0, b.length);
   88     }

The interfaces default method invokes update(b, 0, b.length), which unnecessarily wastes performance 
with superfluous bound checks, but
   86a         if (b == null) {
   86b             throw new NullPointerException();
   86c         }
should be added, to behave same as
   71     public void update(byte[] b, int off, int len) {
in case of null array.

My 2cc.


More information about the core-libs-dev mailing list