RFR 9: 8048124 Read hijrah-config-umalqura.properties as a resource

Alan Bateman Alan.Bateman at oracle.com
Mon Oct 20 15:07:56 UTC 2014

On 20/10/2014 15:53, roger riggs wrote:
> Please review for JDK 9 only.
> To aid the modularization effort, the configuration of the Hijrah 
> calendar
> should move the Hijrah calendar data to a resource.
> At this point, it does not look like there will be other Hijrah calendar
> variants; the function of calendar.properties to configure variants
> is unnecessary and is proposed to be removed.
> Since the other uses of calendars.properties have been eliminated
> the calendars.properties is removed.
> Webrev:
>   http://cr.openjdk.java.net/~rriggs/webrev-hijrah-config-8049376/
> Issue:
>   https://bugs.openjdk.java.net/browse/JDK-8048124
This mostly looks good to me. I just wonder about the removal of the 
doPrivileged in readConfigProperties where you will get null if there is 
something on the stack with restricted permissions.

A minor comment on the @implNote in HijrahChronology is that it has more 
than I would expect, it might be simpler to just say that 
hijrah-config-<calendar-type>.properties is loaded as a resource file. 
Also the import of java.lang.String looks unnecessary.


More information about the core-libs-dev mailing list