[PATCH] Return -1 after throwing internal error

Mandy Chung mandy.chung at oracle.com
Tue Oct 21 02:21:17 UTC 2014

Hi Xiaoguang,

On 10/20/2014 6:31 PM, Xiaoguang Sun wrote:
> Hi All,
> I recently discovered some inconsistency in UnixOperatingSystem_md.c
> that do now return -1 after throwing internal error. It usually
> shouldn't be a problem, but making it more consistent to other code
> within the same file shouldn't be a bad idea.

I'm including serviceability-dev for your patch as UnixOperatingSystem_md.c
belongs to serviceability.

Are you working on a clone of jdk9/dev repo?  src/solaris/native/com/sun/management/UnixOperatingSystem_md.c looks like jdk7 source.

It has been renamed to src/java.management/unix/native/libmanagement/OperatingSystemImpl.c [1]. Can you rebase your patch to the latest jdk9 source and
send it to serviceability-dev?

[1] http://hg.openjdk.java.net/jdk9/dev/jdk/

More information about the core-libs-dev mailing list