RFR: JDK-8049522 - Move @implNote in org.omg.CORBA.ORB to init method

Alan Bateman Alan.Bateman at oracle.com
Fri Oct 24 08:04:28 UTC 2014

On 24/10/2014 00:05, Mark Sheppard wrote:
> Hi,
>    please oblige and review the change
> http://cr.openjdk.java.net/~msheppar/8049522/webrev/
The note in the ORB.init methods looks good. I think it will read a bit 
more smoother if you drop the comma after "When configured".

For the note in the class description "When a singleton ORB .." should 
probably be "When the singleton ORB ...".

I wonder if this statement could be re-worded or even dropped:

"Thus, where appropriate, it is necessary that an application's 
CLASSPATH includes the classes for this alternative ORBSingleton. It 
should be noted the singleton ORB is system wide."

It hints of the CLASSPATH env variable and also not clear what this 
means for applications running in a container. How about:

"An application started on the command line with the java launcher will 
put the classes for the alternative ORB implementation on the class path 
for example".


More information about the core-libs-dev mailing list