Lower overhead String encoding/decoding

Xueming Shen xueming.shen at oracle.com
Mon Oct 27 16:58:42 UTC 2014

On 10/26/2014 02:10 PM, Richard Warburton wrote:
>> The getBytes(ByteBuffer, Charset) method needs a bit more javadoc. You
>> should be able to borrow from text from the CharsetEncoder#encode methods
>> to help with that.
> I've updated the Javadoc with more information about the encoding and made
> these changes. I'm not sure if there's anything else that's missing in this
> case.

Hi Richard,

You have "...reflect the characters read and the byte written..." for the getBtyes(ByteBuffer),
the "characters read and" should be deleted?

I'm not that sure if it is necessary to document it clearly that there would be no dangling
bytes in case of encoding/getBytes(), when there is no enough room/space to encode a
full "char"...


More information about the core-libs-dev mailing list